Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28120 ) Change subject: coding: cosmetic: move 'dtx_prev' to the scope where it's used ...................................................................... Patch Set 1: (1 comment) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/28120/comment/16d9f82b_c652741e PS1, Line 2186: const enum gsm0503_amr_dtx_frames dtx_prev = *dtx; I don't really see the point in this patch. In any case, this should be at the start of the block. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I147f44f1c071e53febeff425a0a7837a0ff10436 Gerrit-Change-Number: 28120 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 May 2022 21:05:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment