Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email ) Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies ...................................................................... Patch Set 3: (1 comment) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586/comment/72dcd2bf_5a54… : PS2, Line 1412: ies[idx] := *; This patch is not perfect, but at least it would make the templates match messages with the Message Class IE present. Though, the big problem of using `*` in record lists is that it allows none or **several** items, not just one :/ This may result in templates matching IEs that are expected to be `omit` by the API user... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1 Gerrit-Change-Number: 38586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:05:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>