Attention is currently required from: laforge, lynxis lazus, pespin.

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email )

Change subject: osmo_io: Factor out and use common send function from backend ......................................................................

Patch Set 3:

(2 comments)

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/35078/comment/3fc2633a_13cfb999 PS1, Line 360:

ack, makes sense, the special case for rc=0 is in the recv path (socket closed). […]

send(len=0) actually succeeds (for TCP sockets) and is currently used in libosmo-netif to check whether a connect() succeeded. The poll-based backend can simply check whether the fd is writable or not. But as Harald mentioned in the SCTP ticket this is not the case with SCTP where write(len=0) returns an error.

File src/core/osmo_io_uring.c:

https://gerrit.osmocom.org/c/libosmocore/+/35078/comment/4d203533_bcb50e25 PS2, Line 196: iofd_handle_send_completion(iofd, rc, msghdr);

The goto can easily be dropped: […]

Ack