Attention is currently required from: dexter, neels, pespin.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168?usp=email )

Change subject: mgw_fsm: Modify RAB on HNB if IuUP local IP addr at MGW changes during MDCX ......................................................................

Patch Set 1:

(3 comments)

File src/osmo-hnbgw/mgw_fsm.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168/comment/d99d1418_f5625754 PS1, Line 299: /* Forward the RAB-AssignmentResponse transparently. This will ensure that the MSC is informed cosmetic: now that there's more indentation, I'd wrap the comment lines so it doesn't go wider than 120 lines as in our coding guidelines (this line and several below)

https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168/comment/45be1603_97c2868a PS1, Line 327: if (mgw_fsm_priv->mdcx_tx_cnt > 3) { log an error here?

https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168/comment/5b0b1357_5e6aea93 PS1, Line 414: LOGL_ERROR Sounds like this is now expected behavior and not an error -> change the log level?