Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38790?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: sctp_server: make it abstract from sctp_proxy logic ...................................................................... sctp_server: make it abstract from sctp_proxy logic Instead of using the sctp_proxy API directly, let the caller pass a module name (handler), which implements the sctp_client behavior. This makes the interaction between modules cleaner, allows to reuse the sctp_server module in other places, and makes testing easier. Change-Id: Iee4202dd4d4e9762fe74ead985aa43343ebdc524 --- M src/osmo_s1gw_sup.erl M src/sctp_client.erl M src/sctp_proxy.erl M src/sctp_server.erl 4 files changed, 53 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/90/38790/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iee4202dd4d4e9762fe74ead985aa43343ebdc524 Gerrit-Change-Number: 38790 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>