Attention is currently required from: laforge, pespin, dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 )
Change subject: mgwpool: Document keepalive feature ......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1: LGTM besides line breaks
File common/chapters/mgwpool.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/d5c43a0d_ac71b... PS1, Line 190: break the lines, consistent to the rest of the document?
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/fdc0a719_22ca7... PS1, Line 190: Pool pool
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/bf82a9de_5314e... PS1, Line 211: NOTE: The `keepalive` feature is disabled by default, and must be explicitly configured in order to enable it. (just curious, not related to review) why?
-
osmith