Attention is currently required from: laforge, pespin, dexter.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 )
Change subject: mgwpool: Document keepalive feature
......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1:
LGTM besides line breaks
File common/chapters/mgwpool.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/d5c43a0d_ac71…
PS1, Line 190:
break the lines, consistent to the rest of the document?
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/fdc0a719_22ca…
PS1, Line 190: Pool
pool
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/bf82a9de_5314…
PS1, Line 211: NOTE: The `keepalive` feature is disabled by default, and must be
explicitly configured in order to enable it.
(just curious, not related to review) why?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a
Gerrit-Change-Number: 33310
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 12:14:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment