Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33538 )
Change subject: nacc_fsm: Add support for NACC with UTRAN and E-UTRAN cells ......................................................................
Patch Set 1:
(2 comments)
File src/nacc_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8821): https://gerrit.osmocom.org/c/osmo-pcu/+/33538/comment/00470315_cbadd494 PS1, Line 280: const Packet_Cell_Change_Notification_t * notif) "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8821): https://gerrit.osmocom.org/c/osmo-pcu/+/33538/comment/715e2232_cf45de54 PS1, Line 318: Target_Cell_4G_Notif; Avoid multiple line dereference - prefer 'notif->Target_Cell.u.Target_Other_RAT_Notif.u.Target_Other_RAT_2_Notif.u.Target_Cell_4G_Notif'