Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email ) Change subject: client: Introduce osmo_pcap_file to prepare support for pcapng ...................................................................... Patch Set 1: (1 comment) File src/osmo_pcap_file.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39288/comment/350e4c6d_f6f85c9c?us… : PS1, Line 38: osmo_pcap_file_global_header_size do we reeally need a function for this? Do we ever expect that there will be a future file format which will return anything but a constant here? Especially since we are not passing any data/context into the function, I have a hard time imagining any future implementation that would not return a constant? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ifd389a2a32897e101c62fd280ddca984d485d373 Gerrit-Change-Number: 39288 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Jan 2025 14:56:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No