Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28894 ) Change subject: Added basic AFC as implemented by SQ5BPF into float_to_bits.c ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-tetra/+/28894/comment/3f6d7125_640201f6 PS1, Line 2: A if this was written by SQ5BPF, you should (as a matter of courtesy, I'd say) set the Author tag in git to his name / email-addr. You would remain the Committer. Changing this during an 'amend' requires some extra flags, AFAIR "git commit --amend --author="John Doe <john(a)doe.org>" should work on this commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1c9343b83739108a1e423c4880e1dc7964656529 Gerrit-Change-Number: 28894 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Wed, 03 Aug 2022 15:55:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment