Attention is currently required from: laforge, pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28039 ) Change subject: Update current NM object state before signalling S_NM_STATECHG ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Well, such comments would be more useful exactly in the signal handlers, so that there is no need to look where and how these signals are emitted. Regarding my proposal to rename S_NM_STATECHG, I agree that we would also need to rename other signals like s/ACK/ACKED/, so I am fine with not doing this. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib46234e3f3e446e866d27b0dfee65edf4af4d2ba Gerrit-Change-Number: 28039 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 May 2022 23:32:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment