Attention is currently required from: laforge, pespin.
neels has posted comments on this change by neels. (
https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email )
Change subject: rate_ctr,CTRL[1/2]: GET using rate_ctr_group_set_name()
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS2:
(the "problem" being that we already have a
'name' used for counter groups in this API... […]
actually i already use
'name' for naming in this patch version.
File src/core/rate_ctr.c:
https://gerrit.osmocom.org/c/libosmocore/+/37881/comment/faf07fba_8fc33d91?… :
PS2, Line 284: osmo_quote_str(name, -1));
it is semantically tied, one without the other leaves
a loophole... […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I841a12f76e6fcb2bd7aecb5f4b1707d9ec927137
Gerrit-Change-Number: 37881
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Sep 2024 02:24:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>