Attention is currently required from: msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29178 )
Change subject: Properly handle send() return code
......................................................................
Patch Set 1:
(1 comment)
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/29178/comment/6af91c18_62c99515
PS1, Line 1334: LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", (ret == -1) ? strerror(errno) : strerror(-ret));
I'm not terribly concerned with such a system (see "errno -l") - feel free to pull me in as reviewer […]
why do you say you don't care about such systems? Do you know the code errors can change even within linux system running on different platforms?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/29178
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: If9b80e855b740254d5414ea50b4ce594855da8e9
Gerrit-Change-Number: 29178
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev
msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: msuraev
msuraev@sysmocom.de
Gerrit-Comment-Date: Tue, 30 Aug 2022 12:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: msuraev
msuraev@sysmocom.de
Gerrit-MessageType: comment