Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38393?usp=email ) Change subject: _testenv: Avoid running make check when building IUT ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I definitely support this patch. I was having problems running TTCN-3 tests against osmo-s1gw in WIP state, when not all unit tests were passing. I would give CR+2 immediately, but let's see what others think. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b5dd0947a1bd937775a74bceb88dcf3bbcf914b Gerrit-Change-Number: 38393 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 17:14:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes