Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472?usp=email )
Change subject: stp: IPA: Introduce test TC_beat ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File stp/STP_Tests_IPA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40472/comment/403a5291_c3598... : PS3, Line 495: var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; : v
Not critical, but this is another place where additional variables could be avoided by passing `IPAC […]
I'd agree. But my mind seems to rememer that somehow enum2int only works on typed variables and not immediate constants?
-
laforge