[S] Change in libosmo-sigtran[master]: ipa: Split msgb generation into its own helper function - gerrit-log

22 Jan 2025


      Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email )
Change subject: ipa: Split msgb generation into its own helper function
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/ipa.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395/comment/c7017733_68e7cd... :
PS1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA);
...
The order was sapped in sua_tx_xua_asp(), not in sua_tx_xua_as() hence why I got confused :D
Done
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7
Gerrit-Change-Number: 39395
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 22 Jan 2025 14:56:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de