Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32552
)
Change subject: osmo-bts-trx: fix trx_ctrl_read_cb(): do not send CMDs twice
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bts-trx/trx_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/7763e3c0_3c99b5f8
PS1, Line 743: re-schedule last cmd in rc seconds time
I am wondering how this is supposed to work, given
that we have unlinked the last cmd at this point […]
Looks like I introduced
related issues back in 4444262a6ab1e1e231ea81c4ec990f1a1f571a1f
(
https://gerrit.osmocom.org/c/osmo-bts/+/25517).
But that also explains why it is like this: Allow calling trx_if_flush/close from within
TRXC callback.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32552
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df
Gerrit-Change-Number: 32552
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 02 May 2023 09:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment