Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31914 )
Change subject: {context,select}: cosmetic: use OTC_SELECT instead of osmo_ctx->select
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
I don't really see the improvement here. The OTC_GLOBAL / OTC_SELECT constants are convenience helpers for the user who shouldn't care about the implementation. But for the implementation internally, there's nothing wrong with the way how current code is written.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31914
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2aa03c7c68b7cca17eebbf858ada7c42f0d0a1da
Gerrit-Change-Number: 31914
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 14 Mar 2023 15:25:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment