laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/26651 )
Change subject: mgcp_client: add new codec IUFP as VND.3GPP.IUFP
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/c/osmo-mgw/+/26651/4/src/libosmo-mgcp-client/mgc…
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/26651/4/src/libosmo-mgcp-client/mgc…
PS4, Line 62: { CODEC_IUFP, "VND.3GPP.IUFP/16000/1" },
I think more than irrelevant it's wrong specifying
it here, since that's actually negotiated/announc […]
yes, it is dynamically
specified during the SDP handshake. THat's what the 'rtpmap' is all about.
So the MGW must deal with it based on whatever the rtpmap says.
I'm not sure where / how exactly this table is used,
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/26651
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3
Gerrit-Change-Number: 26651
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Jan 2022 13:18:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment