Attention is currently required from: neels, fixeria, daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197 )
Change subject: ggsn: Introduce test TC_pdp4_act_update_teid/teic
......................................................................
Patch Set 4:
(2 comments)
File ggsn_tests/GGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197/comment/425e91d7_c053…
PS4, Line 391: setverdict(fail);
Add a message to indicate what failed? […]
I can
improve both as a follow up patch using shutdown() helper.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197/comment/761b3052_7f41…
PS4, Line 501: espect
expect
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic6af25866bf7efc2cabf029e49abaf15d5857592
Gerrit-Change-Number: 27197
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Feb 2022 16:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment