Change in osmo-cbc[master]: sbcap: Improve handling of WriteReplaceWarnResponse - gerrit-log

29 Jul 2022


      Attention is currently required from: osmith, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28824 )
Change subject: sbcap: Improve handling of WriteReplaceWarnResponse
......................................................................
Patch Set 3:
(1 comment)
File src/sbcap_link_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/329b4988_3e851289 
PS3, Line 256: 	/* static const long asn_VAL_19_SBcAP_id_Cause = 1; */
...
did you leave this on purpose?
this appears to be meant to explain the '1' in the line below. I don't know why we cannot use that asn_VAL_19_SBcAP_id_Cause. Because it's generated by asn1c as static?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28824
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I0a4d5bdbb6c4fd3870a4f4ebf226668b70fea06a
Gerrit-Change-Number: 28824
Gerrit-PatchSet: 3
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Gerrit-MessageType: comment