Attention is currently required from: lynxis lazus.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )
Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/8b9dd9ed_8d2... : PS1, Line 8:
No. This patch stays exactly like this. Both messages were wrong, and now they agree with the spec. […]
Just to be clear, both messages were just plain wrong, there is no "different" wrong or "different" problems, It absolutely does not matter how many bytes or which bytes were wrong, they didn't agree with the spec, there is no "a little bit" wrong when it comes to messages based on a spec, so those messages were just completely wrong, period.