Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30724 ) Change subject: gsm_08_58: add IEI to signal HR GSM RTP format via RSL ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/30724/comment/f0841a1a_44089297 PS2, Line 12: packets. (In the receiving direction the BTS automatically detects the If the BTS automatically detects the RTP format upon rx, why cannot we simply detect it automatically at osmo-mgw upon rx too and be done with it? IMHO this is the incorrect way to go. I think it would make more sense to simply have BTS_FEATURE indicating the BSC the formats which the BTS can handle, so that the BSC can configure the MGW to use the proper codec to transmit data to it. On the other direction, we don't really care, the MGW should be able to cope with all of them. If at all, add a VTY config to osmo-bts to choose using one format or another to transmit. Patchset: PS2: I'd like to hear feedback from others here, since I don't think the current proposal in the patch is the way to go. I'm happy to discuss the issue further and change opinion if others think differently. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I843c8a0cbe5898311f3af3294cec7c8bc96c4eb8 Gerrit-Change-Number: 30724 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Jan 2023 15:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment