Attention is currently required from: laforge.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31620 )
Change subject: rsl: put values for Channel Mode into enums
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1:
1+1=2
File include/osmocom/gsm/protocol/gsm_08_58.h:
https://gerrit.osmocom.org/c/libosmocore/+/31620/comment/23d6e0f7_e59acfb4
PS1, Line 544: RSL_CMOD_CSD_T_14400 = 0x18,
see my related comment in the TTCN3 patch: might make
sense to standardize on the XXkY notation, so […]
ack, done in follow-up patch:
https://gerrit.osmocom.org/c/libosmocore/+/31647
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31620
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I25bfd02aa1428a35492b20376a31635a442e545f
Gerrit-Change-Number: 31620
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 03 Mar 2023 10:13:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment