Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149?usp=email )
Change subject: stp: prepare for testing M3UA-over-TCP
......................................................................
Patch Set 1:
(1 comment)
File stp/STP_Tests_M3UA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149/comment/77076a36_bfddb...
PS1, Line 285: if (not Misc_Helpers.f_osmo_repo_is("nightly")) {
I don't see why do we want to add this code here, what's the benefit? we then need to maintain and remove this at some point. Just let it fail below if running against some other version.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5d0b05aa434c057ad379125ac293f5fc9a240b6f
Gerrit-Change-Number: 36149
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:04:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment