Attention is currently required from: fixeria, msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30329 )
Change subject: mobile: gsm48_rr_set_mode(): check rc of rsl_dec_chan_nr()
......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30329/comment/5c2a8033_7a680fc7
PS1, Line 3435: LOGP(DRR, LOGL_ERROR, "Couldn't decode RSL channel
number\n");
It's better to print chan_nr so it's
immediately clear which channel number was not decoded.
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30329
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9ab18bdaf41a29fcd32a7060668ef9db07b8cf7e
Gerrit-Change-Number: 30329
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <axilirator(a)gmail.com>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Nov 2022 09:35:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment