Attention is currently required from: osmith, daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/30157
)
Change subject: osmux: Rotate over available Osmux CID when allocating a new one
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp/mgcp_osmux.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/30157/comment/09376b3a_402b5adc
PS1, Line 748: start_j = next_free_osmux_cid_lookup & 0x07;
I think it would be clearer if you used /8 and %8
here, I had to read it three times.
Since anyway the code it's doing bitwise
stuff on the bitmask with i and j I thought it's understandable enough.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/30157
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I9dfbcc5e4b4c61ce217020e533d68fbcfa6b9f56
Gerrit-Change-Number: 30157
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 15 Nov 2022 14:48:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment