Attention is currently required from: osmith, fixeria, pespin, dexter.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33296 )
Change subject: ASCI: Retrieve NCH position from System Information 1
......................................................................
Patch Set 7:
(2 comments)
File src/common/sysinfo.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/d7e2b2eb_eda4740d
PS6, Line 177: /* H <NCH Position : bit (5)> */
This is CSN. […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/58314759_bee0df0d
PS6, Line 180: return -EINVAL;
maybe ENOTSUP? I think also important would be a comment to explain that this is not an error.
An error message makes no sense, because having no NCH support is not an error.
I changed it to -ENOTSUP. This makes more sense.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/33296
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I799a27179d478d4ff577d8bc47ae524834851e85
Gerrit-Change-Number: 33296
Gerrit-PatchSet: 7
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
Gerrit-MessageType: comment
jolly