Attention is currently required from: kirr.

pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39533?usp=email )

Change subject: trx_toolkit/transceiver: Do not forward nor log from under tx_queue_lock ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

File src/target/trx_toolkit/transceiver.py:

https://gerrit.osmocom.org/c/osmocom-bb/+/39533/comment/9cb3947c_b8ede83d?us... : PS1, Line 322: self._tx_queue = [msg for msg in self._tx_queue if msg.fn > fn] sounds like it may be easier (more performant?) having an "else: new_tx_queue.append(msg)" above while iterating the queue, and then here do: "self._tx_queue = new_tx_queue"