Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37268?usp=email )
Change subject: pfcp_peer: PFCP peer implementation
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/osmo_s1gw_sup.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37268/comment/b490e195_40b0…
:
PS9, Line 68: UpfRemPort
I find this slightly confusing, why not name it UpfRemAddr, like UpfLocAddr?
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37268?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7bad0069dca2111006039d12e744a2bd6d2cb86e
Gerrit-Change-Number: 37268
Gerrit-PatchSet: 9
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Aug 2024 08:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes