Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27463 ) Change subject: bsc_nat_sccp_inst: store ss7_inst ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: So IIUC, before this commit, the field existed in the struct but was never user? Strange. File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27463/comment/8e8965f0_708d6daf PS1, Line 273: osmo_ss7_instance_destroy(sccp_inst->ss7_inst); You could null the pointer like done above. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I9a8b69fb3df17c85a67958fbca88948573d39694 Gerrit-Change-Number: 27463 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Mar 2022 15:00:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment