Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33123 )
Change subject: encoding: only RFN needed in write_immediate_assignment(_reject)()
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
Re-adding +1 and assuming Vadim is fine after I updated the commit message with what I wrote in the […]
Yeah, I am generally fine. But I would change the commit name to: `encoding: pass RFN to write_immediate_assignment(_reject)()`. Not going to block though.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/33123
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If9b758434c00f2a3868534d5be84946809c989a9
Gerrit-Change-Number: 33123
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 02 Jun 2023 12:29:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment