Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552 )

Change subject: osmo-bts-trx: fix trx_ctrl_read_cb(): do not send CMDs twice ......................................................................

Patch Set 2:

(1 comment)

File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/c381a351_47a48f80 PS1, Line 737:

what about moving "trx_ctrl_send(l1h);" here before call to trx_ctrl_rx_rsp()? this way we don't get […]

I was thinking about this too. But this would make the logging/flow a bit confusing:

* first we say we received a response for previously sent command, * then we send the next command from the queue, * and then we handle the received response for previous command.

IMO, it's more logical as it is now.