Attention is currently required from: domi, laforge, pespin.

csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................

Patch Set 22:

(2 comments)

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/4d89cb4c_33355c29?usp=... : PS21, Line 1828: get_object_identity_string(object_id_state[4]),

Well, it can clearly be seen in here that's not the case. […]

If you want I send you a printscreen that it looks perfect on my side.

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/44d22da8_c153bbca?usp=... : PS21, Line 1860: !FIND_ELEM(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))) {

BTW, FYI, in general in if the column doesn't fit exactly at the tab boundary, you need to add some […]

On my end 4 spaces equals a tab, never changed it, this is the default behavior. Should it be 8 spaces?

Anyway, I hope all the cosmetics are acceptable, we really need to move to actual logic changes of the code.