neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30495 ) Change subject: nft: end each rule in semicolon ...................................................................... nft: end each rule in semicolon also cosmetic: put the line ending in a separate PRINTF so that adding or removing items to the rule in future patches does not affect the line ending. Change-Id: I6ff6f59fb24a18596aa60848fb00ac70deb1985f --- M src/osmo-upf/upf_nft.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-upf/upf_nft.c b/src/osmo-upf/upf_nft.c index 0b270ff..4dfea6c 100644 --- a/src/osmo-upf/upf_nft.c +++ b/src/osmo-upf/upf_nft.c @@ -149,7 +149,8 @@ /* Change the TEID in the header to the one to_peer expects */ OSMO_STRBUF_PRINTF(sb, " @ih,32,32 set 0x%08x", to_peer->teid_remote); - OSMO_STRBUF_PRINTF(sb, " counter\n"); + OSMO_STRBUF_PRINTF(sb, " counter"); + OSMO_STRBUF_PRINTF(sb, ";\n"); return sb.chars_needed; } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I6ff6f59fb24a18596aa60848fb00ac70deb1985f Gerrit-Change-Number: 30495 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged