Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30192 ) Change subject: firmware/sniffer: Add + use 16bit ringbuffer ...................................................................... Patch Set 1: (2 comments) File firmware/libcommon/include/ringbuffer.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1073): https://gerrit.osmocom.org/c/simtrace2/+/30192/comment/1a973922_030f7d2a PS1, Line 40: typedef struct ringbuf16 { do not add new typedefs File firmware/libcommon/source/ringbuffer.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1073): https://gerrit.osmocom.org/c/simtrace2/+/30192/comment/2929bf77_9fa9a863 PS1, Line 147: } else { else is not generally useful after a break or return -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ifde054fbfe7f753b61e7d3409c56eca6e0faeb4b Gerrit-Change-Number: 30192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 16 Nov 2022 18:05:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment