fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37220?usp=email ) Change subject: Makefile: use $(shell ...) to invoke pkg-config ...................................................................... Makefile: use $(shell ...) to invoke pkg-config This way the values are evaluated by make itself (not by the shell), and can be seen in the output when running make. Change-Id: I44db058c92377b741e24c7cdf4891ae020f37ff1 --- M src/Makefile 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: neels: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Verified diff --git a/src/Makefile b/src/Makefile index 3591ece..ef1c7ed 100644 --- a/src/Makefile +++ b/src/Makefile @@ -1,5 +1,5 @@ -CPPFLAGS ?= -g -O0 -Wall `pkg-config --cflags libosmocore` `pkg-config --cflags qmi-glib` -LIBS ?= `pkg-config --libs libosmocore` `pkg-config --libs qmi-glib` +CPPFLAGS ?= -g -O0 -Wall $(shell pkg-config --cflags libosmocore qmi-glib) +LIBS ?= $(shell pkg-config --libs libosmocore qmi-glib) all: osmo-qcdiag-log MODS_LOG = gprs_l1.c gprs_rlc.o gprs_mac.o diag_gsm.o diag_log.o diag_log_gsm.o diag_log_gprs.o diag_log_wcdma.o diag_log_umts.o diag_log_qmi.o diag_dpl.o diag_log_simcard.o diag_event.o -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/37220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: I44db058c92377b741e24c7cdf4891ae020f37ff1 Gerrit-Change-Number: 37220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged