Attention is currently required from: pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )
Change subject: Introduce per-BTS timers, RLC timer commands ......................................................................
Patch Set 12:
(2 comments)
This change is ready for review.
File src/osmo-bsc/bsc_init.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/f585d0ed_a267887c PS3, Line 241: bts->timer_groups[OSMO_BSC_BTS_TDEF_GROUPS_RLC].tdefs = bts->gprs.cell.rlc_cfg.timers;
Hm yeah didn't think of that, I'll remove the timers from the `rlc_cfg` struct.
Done
File tests/nanobts_omlattr/nanobts_omlattr_test.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/37f64bbc_70226341 PS2, Line 228: 0x02, 0x00, 0x02, 0xa3, 0x00, 0x09,
to me they already are aligned (the timer names and the respective values below). […]
I have aligned all columns vertically