Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email )
Change subject: sctp_server: pass MME addr/port to sctp_proxy as opaque data ......................................................................
Patch Set 1:
(1 comment)
File src/sctp_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786/comment/53b281fa_10537... : PS1, Line 64: start_link(Aid, {MmeAddr, MmePort}) ->
I wonder what's the point in maintaining the 2 versions of the start_link here...
It's because `gen_server` is now passing both MME address and MME port as one argument (tuple), but the existing API expects two separate arguments. I could change the existing API rather than adding the new `/2` wrapper, either way is fine with me.