Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31031 )

Change subject: Add more L1 signals to common part ......................................................................

Patch Set 3:

(1 comment)

File include/osmocom/abis/e1_input.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/31031/comment/f6676f0a_d45d0908 PS1, Line 245: S_L_INP_LINE_LOS, : S_L_INP_LINE_NOLOS, : S_L_INP_LINE_AIS, : S_L_INP_LINE_NOAIS, : S_L_INP_LINE_RAI, : S_L_INP_LINE_NORAI, : S_L_INP_LINE_SLIP_RX, : S_L_INP_LINE_SLIP_TX,

indeed, we still don't have a description of how this signal works. […]

Here is a description, but still don't know where to put it:

The sa_bits byte contains the Sa bits in TS 0, if multi frame is used: bit 7 = Sa8, bit 6 = Sa7, bit 5 = Sa5, bit 4 = Sa4, bit 3 = Sa64, bit 2 = Sa63, bit 1 = Sa62, bit 0 = Sa61. The sa_bits byte contains the Sa bits in TS 0, if double frame is used: bit 7 = Sa8, bit 6 = Sa7, bit 5 = Sa5, bit 4 = Sa4, bit 0 = Sa6. The received Sa bits are reported whenever they change (and are stable for some frames, depending on the implementation). Before any report, all Sa bits are assumed to be set to 1. Setting sa_bits byte will change the transmitted Sa bits on TS0. Before setting them, all Sa bits are transmitted as 1.