Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email )
Change subject: bssgp: Fix non-uniqe rate_ctr ids
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I now see this was already proposed here: https://gerrit.osmocom.org/c/libosmocore/+/13206 […]
At least from the view of osmo-gbproxy we absolutely have the same BVCI on multiple NSEs so I would say this fix is fine.
I still think having a string identifier might be a better option in the future. Then the "index" could be something like "NSE00101-BVC00023".
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I782e11a75a8adc10292238fde46bf9c3975d970d
Gerrit-Change-Number: 41456
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 19 Nov 2025 15:46:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de