Change in libosmocore[master]: core/utils.h: make use of OSMO_LIKELY in OSMO_ASSERT - gerrit-log

8 Feb 2022


      Attention is currently required from: osmith, pespin, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27047 )
Change subject: core/utils.h: make use of OSMO_LIKELY in OSMO_ASSERT
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/core/utils.h:
https://gerrit.osmocom.org/c/libosmocore/+/27047/comment/de757743_94171df9 
PS3, Line 115: 	if (OSMO_LIKELY(exp)) ; \
...
I'm a bit lost here. Why not use: […]
Ack
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I29b32a2477ec92762f8f0ce5e5c5a30810f6abbe
Gerrit-Change-Number: 27047
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: dexter pmaier@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 08 Feb 2022 16:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment