[S] Change in ...osmo-s1gw[master]: s1ap_proxy: properly handle E-RAB RELEASE IND - gerrit-log

14 Nov 2024


      Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38767?usp=email )
Change subject: s1ap_proxy: properly handle E-RAB RELEASE IND
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38767/comment/951e2b1c_921d8... :
PS1, Line 447:     handle_ies(Content, ?'id-E-RABItem', S#proxy_state{rel_kind = cmd});
it probably makes more sense to set this wherever we parse the message type "RELEASE COMMAND"? or there's no such place?
-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38767?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Id1b77ef59818d6416326477a25e9866ab636b3ad
Gerrit-Change-Number: 38767
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 14 Nov 2024 11:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes