Attention is currently required from: arehbein, laforge, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33201 )
Change subject: stream: Add and use IPA send function ......................................................................
Patch Set 12:
(3 comments)
Patchset:
PS12: Some of your own comments seem to not be addressed yet.
File examples/ipa-stream-client.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/e5c8d326_1321339e PS11, Line 109: if (osmo_ipa_process_msg(msg) < 0) {
Remove this, it's now handled in the segmentation_cb
what about this comment?
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/bbad6fe2_9d515c57 PS12, Line 57: #define IPAC_PROTO_UNSPECIFIED -1 it's a bit strange to declare this here while others are probably declared somewhere else?
-
pespin