Attention is currently required from: arehbein, laforge, daniel.

View Change

3 comments:

• Patchset:

  • Patch Set #12:

    Some of your own comments seem to not be addressed yet.

• File examples/ipa-stream-client.c:

  • Patch Set #11, Line 109: if (osmo_ipa_process_msg(msg) < 0) {

    Remove this, it's now handled in the segmentation_cb

    what about this comment?

• File include/osmocom/netif/ipa.h:

  • Patch Set #12, Line 57: #define IPAC_PROTO_UNSPECIFIED -1

    it's a bit strange to declare this here while others are probably declared somewhere else?

To view, visit change 33201. To unsubscribe, or for help writing mail filters, visit settings.