Attention is currently required from: fixeria, laforge, osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email )

Change subject: asp: Introduce support to configure and enable TCP keep-alive ......................................................................

Patch Set 3:

(1 comment)

File src/ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/86852ad5_5cbf00... : PS3, Line 801:

mh. […]

This is already used in several places in our code base, check with:

$ ag "^\s*(void)" libosmo* osmo-* | wc -l 141

This is also allowed just fine by the C specs: https://stackoverflow.com/questions/79100782/compiler-complains-that-an-unus...

I'd prefer keeping this well-established way which is also useful in general for all compilers instead of sticking to something coverity specific.

If you don't agree, I can remove the rc value completely and be done with it.