Attention is currently required from: fixeria, laforge, osmith.
View Change
1 comment:
File src/ss7_asp.c:
Patch Set #3, Line 801:
mh. […]
This is already used in several places in our code base, check with:
$ ag "^\s*\(void\)" libosmo* osmo-* | wc -l
141
This is also allowed just fine by the C specs:
https://stackoverflow.com/questions/79100782/compiler-complains-that-an-unused-variable-is-used-when-simply-a-cast-to-void-is
I'd prefer keeping this well-established way which is also useful in general for all compilers instead of sticking to something coverity specific.
If you don't agree, I can remove the rc value completely and be done with it.
To view, visit change 40481. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1
Gerrit-Change-Number: 40481
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Sat, 21 Jun 2025 14:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>