Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32194 )
Change subject: nm: Apply BTS/TRX/TS OML Attributes through NM FSMs ......................................................................
Patch Set 2:
(1 comment)
File src/common/nm_bb_transc_fsm.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32194/comment/2c76dfaf_7d5b79c4 PS2, Line 132: (struct abis_om_fom_hdr *)msgb_l3(setattr_data->msg))->msg_type
can we not afford a local variable? IMHO it's really unusual to typ-cast a poinetr to msgb_l3 and […]
yes I can do so. I'll probably do it in a followup commit though, since there's a bunch of commits doing several iterations of cleanup in the several same places.
-
pespin