Attention is currently required from: neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31610 )

Change subject: vty: msc / codec-list: forbid duplicate entries ......................................................................

Patch Set 1:

(3 comments)

File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/0c04234f_d42e1e86 PS1, Line 2730: || argv[i][1] != 'r' this indentation looks wrong.

https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/3b06bb68_1103b6ee PS1, Line 2731: || (argv[i][0] != 'h' && argv[i][0] != 'f') comparing first argv[i][0] and after argv[i][1] is way more "expected" ;)

https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/18f844c5_349f7874 PS1, Line 2740: if (strncmp("hr", argv[i], 2) == 0) tmp[i].hr = (argv[i][0] == 'h' ? 1 : 0);