Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27960 ) Change subject: smscb: Store ETWS input state from CBSP ...................................................................... Patch Set 1: (3 comments) File src/osmo-bsc/smscb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/3eda2319_7ff901ba PS1, Line 475: LOG_BTS(bts, DCBS, LOGL_NOTICE, "ETWS PN broadcast voa PCH disabled (cause=%s)\n", voa? https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/eb67536b_e778cb14 PS1, Line 510: memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE); did you check previously you are not going to read out of buffer in wrepl here? by checking msg len or whatever. https://gerrit.osmocom.org/c/osmo-bsc/+/27960/comment/205b1bea_5f1939ce PS1, Line 705: osmo_timer_del(&bts->etws.timer); not related to this patch, but you could delete this timer before setting it up in line 542, not sure if that's a good idea. I'd move the osmo_timer_setup to be called once during bts object creation. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ide74638880d7e3c6a7c774bf6320d3dce4b11c74 Gerrit-Change-Number: 27960 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Apr 2022 16:49:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment