Attention is currently required from: laforge.

View Change

3 comments:

• File src/osmo-bsc/smscb.c:

  • Patch Set #1, Line 475: LOG_BTS(bts, DCBS, LOGL_NOTICE, "ETWS PN broadcast voa PCH disabled (cause=%s)\n",

    voa?

  • Patch Set #1, Line 510: memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE);

    did you check previously you are not going to read out of buffer in wrepl here? by checking msg len or whatever.

  • Patch Set #1, Line 705: osmo_timer_del(&bts->etws.timer);

    not related to this patch, but you could delete this timer before setting it up in line 542, not sure if that's a good idea.
    I'd move the osmo_timer_setup to be called once during bts object creation.

To view, visit change 27960. To unsubscribe, or for help writing mail filters, visit settings.